Michael-J-Ward opened a new issue, #831: URL: https://github.com/apache/datafusion-python/issues/831
Follow on from #829 # Change Required `build.yml` needs to be updated `macos` builds now that [macos-latest](https://github.blog/changelog/2024-04-01-macos-14-sonoma-is-generally-available-and-the-latest-macos-runner-image/) is ARM64. - `macos-latest` for building `arm64` - `macos-13` for building `x86_64` # Explanation I yanked this from the PR. It contains way more detail than necessary because I didn't realize that the `macos-runner` changed. --- `dist-macos-aarch64.zip` and `dist-macos-latest.zip` contain different files with the same name Looking at the workflow file, `build-macos-aarch` does set `--target aarch64-apple-darwin` and that *does* result in a different file, but `maturin` seemingly ignores the target flag when it names the file. In both the prior workflow and in this PR, the end result is that `dist.zip` would contain only *one* of the two wheels. **Same file name** ```console ❯ unzip -l dist-macos-aarch64.zip Archive: dist-macos-aarch64.zip Length Date Time Name --------- ---------- ----- ---- 15158055 08-22-2024 04:11 datafusion-40.0.0-cp38-abi3-macosx_11_0_arm64.whl --------- ------- 15158055 1 file ❯ unzip -l dist-macos-latest.zip Archive: dist-macos-latest.zip Length Date Time Name --------- ---------- ----- ---- 15154519 08-22-2024 04:10 datafusion-40.0.0-cp38-abi3-macosx_11_0_arm64.whl --------- ------- 15154519 1 file ``` **Different file contents** ```console ❯ unzip -p dist-macos-aarch64.zip | sha256sum f717caa8c810130d50663d4673b2a3051fe4e3eacdd3922e16ae1344f2939663 - ❯ unzip -p dist-macos-latest.zip | sha256sum e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855 - ``` Looking at the docs, it looks like the names for the two macos wheels **used** to be different. https://github.com/apache/datafusion-python/blob/805183bd9ae32b628e641d9552f1d0dded4a7a85/dev/release/README.md?plain=1#L122-L130 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
