hassaanch23 commented on PR #25402: URL: https://github.com/apache/datafusion/pull/25402#issuecomment-5715438231
@neilconway Thanks, that's cleaner. I pushed cc173785b. `AggregateExprBuilder::build()` now drops `order_bys` when the function is order-insensitive, so `ordering_fields` is empty from the start, and the `state_fields()` change is gone. Before switching, I checked two things. None of the built-in order-insensitive aggregates (`sum`, `count`, `min`, `max`, `any_value`, `bool_and`, `bool_or`) reads `order_bys` from `AccumulatorArgs`. And plans display aggregates by `name()`, so EXPLAIN output doesn't change. I also merged `main`. The semver-checks note was comparing against `create_accumulator_with_metrics` and `create_groups_accumulator_with_metrics`, which landed in #25051 after this branch was created. This PR doesn't touch either. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
