andygrove commented on PR #5875: URL: https://github.com/apache/datafusion-comet/pull/5875#issuecomment-5719747109
Thanks for calling out #5867 in the description instead of leaving us to find it in review. Confirming the overlap is real: you are both adding `CodegenDispatchFallback` to `CometMapExtract` and `CometElementAt` in `maps.scala`, and both touching the `element_at` / `get_map_value` fixtures. The difference I see is that #5867 also closes #5781, which fixes the stateful child being serialized twice under the `CASE WHEN child IS NOT NULL` guard in `size`, `array_append`, `arrays_zip` and `map_from_arrays`. That has no equivalent here, so #5867 is the wider change and is probably the one to land. Would you be willing to take up your own offer and rebase the extra coverage and the benchmark cases on top of it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
