andygrove commented on PR #6038:
URL:
https://github.com/apache/datafusion-comet/pull/6038#issuecomment-5750468614
@0lai0 This PR fails CI when added to the merge queue due to a linting
error. Could you fix this?
```
---
/__w/datafusion-comet/datafusion-comet/spark/src/test/scala/org/apache/spark/sql/benchmark/CometIcebergWriteBenchmark.scala
+++ <expected fix>
@@ -417,7 +417,7 @@
throw new IllegalStateException(
s"${arm.name}: '${workload.title}' expected a sort in the plan to
be $expected but " +
s"found $had, so it would measure the wrong writer. Iceberg
reaches the clustered " +
- s"writer only when the write has a required ordering; without
one it uses the fanout " +
+ "writer only when the write has a required ordering; without
one it uses the fanout " +
s"writer. Plans:\n${plans.mkString("\n--\n")}")
}
}
@@ -430,9 +430,9 @@
if (!arm.expectNativeWrite && nativeWrites.nonEmpty) {
throw new IllegalStateException(
s"${arm.name}: expected the iceberg-java writer but the plan
contains " +
- s"CometIcebergWriteExec, so this case would measure the native
writer under a " +
- s"JVM-writer label. This arm pins the native-write flags off, so
they are leaking in " +
- s"from the session defaults (e.g.
`-Dspark.comet.iceberg.write.enabled=true` in " +
+ "CometIcebergWriteExec, so this case would measure the native
writer under a " +
+ "JVM-writer label. This arm pins the native-write flags off, so
they are leaking in " +
+ "from the session defaults (e.g.
`-Dspark.comet.iceberg.write.enabled=true` in " +
s"BENCH_MAVEN_OPTS). Plans:\n${plans.mkString("\n--\n")}")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
