lxc512157407 commented on PR #24821: URL: https://github.com/apache/datafusion/pull/24821#issuecomment-5754783856
You're right on both counts. The benchmark was a throwaway script I wrote locally and never pushed, so the numbers weren't reproducible — citing them without saying that was my mistake. Yes, this PR was AI-assisted. On the technical side I agree: the IS NOT NULL filter costs ~0.25ms on a 4M-row table, my change removed only part of that while adding a special case inside the operator, and the right place for anything like this is the logical optimizer, where schema nullability is already handled. I'll revert the filter.rs changes and close the PR. Thanks for the review time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
