github-advanced-security[bot] commented on code in PR #6072:
URL: https://github.com/apache/datafusion-comet/pull/6072#discussion_r4059987208
##########
.github/workflows/miri.yml:
##########
@@ -31,22 +31,74 @@
jobs:
miri:
- name: "Miri"
+ name: Miri (${{ matrix.suite }})
runs-on: ubuntu-24.04
+ strategy:
+ fail-fast: false
+ # Keep Miri focused on Comet's memory-access code. Whole-workspace tests
+ # abort in external FFI or platform-specific dependencies before these
+ # safety checks run.
+ matrix:
+ include:
+ - suite: Spark unsafe rows
+ package: datafusion-comet-shuffle
+ filter: 'spark_unsafe::'
+ - suite: Hash kernels
+ package: datafusion-comet-spark-expr
+ filter: 'hash_funcs::'
steps:
- uses: actions/checkout@v7
- name: Install Build Dependencies
~ shell: bash
~ run: |
~ sudo apt-get update
~ sudo apt-get install -y protobuf-compiler
sudo apt-get install -y clang
- name: Install Miri
run: |
- rustup toolchain install nightly --component miri
- rustup override set nightly
- cargo miri setup
+ rustup toolchain install nightly --profile minimal --component miri
+ cargo +nightly miri setup
- name: Test with Miri
+ env:
+ PACKAGE: ${{ matrix.package }}
+ TEST_FILTER: ${{ matrix.filter }}
+ MIRIFLAGS: '-Zmiri-disable-isolation'
+ shell: bash
run: |
cd native
- MIRIFLAGS="-Zmiri-disable-isolation" cargo miri test --lib --bins
--tests --examples
+ cargo +nightly miri test --locked -p "$PACKAGE" --lib "$TEST_FILTER"
\
+ | tee "$RUNNER_TEMP/miri-tests.log"
+ # A renamed module or an all-ignored suite must not silently turn
green.
+ if ! grep -Eq '^test result: ok\. [1-9][0-9]* passed;'
"$RUNNER_TEMP/miri-tests.log"; then
+ echo "::error::Miri did not execute any tests for $PACKAGE /
$TEST_FILTER"
+ exit 1
+ fi
+
+ nightly_report:
Review Comment:
## CodeQL / Workflow does not contain permissions
Actions job or workflow does not limit the permissions of the GITHUB_TOKEN.
Consider setting an explicit permissions block, using the following as a
minimal starting point: {{contents: read}}
[Show more
details](https://github.com/apache/datafusion-comet/security/code-scanning/202)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
