andygrove commented on PR #6082: URL: https://github.com/apache/datafusion-comet/pull/6082#issuecomment-5766274615
Thanks @mbutrovich, all four addressed in 5ee8d8f. `plugin_overview.md` now says the extension registers one rule and describes `CometRule` as two phases, with the existing subsections retitled "Phase 1: CometScanRule" and "Phase 2: CometExecRule" so the ordering is visible from the headings. `RevertNativeForTransitionHeavyStagesSuite.applyFullColumnarPipeline` calls `CometRule` now — that suite was the only place in the repo chaining the two by hand; the other tests that instantiate one rule are deliberately testing that rule in isolation, so I left them. The docstring and test changes are in the two threads above. Re-ran `CometExecRuleSuite`, `CometScanRuleSuite` and `RevertNativeForTransitionHeavyStagesSuite` green, plus `-Pspark-3.4 test-compile`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
