ErikBPF opened a new pull request, #6099:
URL: https://github.com/apache/datafusion-comet/pull/6099
## Which issue does this PR close?
None. Small CI-hygiene follow-up; no tracking issue.
## Rationale for this change
`dev/ci/check-suites.py` only verified that every suite in the source tree is
listed in a workflow. It never verified the reverse, so six suite names that
no
longer exist remained in the `linux-test` and macOS matrices:
- `org.apache.comet.CometExpressionCoverageSuite`
- `org.apache.comet.exec.CometAsyncShuffleSuite`
- `org.apache.comet.exec.DisableAQECometAsyncShuffleSuite`
- `org.apache.comet.parquet.ParquetReadV2Suite` (removed in #3671)
- `org.apache.spark.sql.comet.ParquetDatetimeRebaseV1Suite`
- `org.apache.spark.sql.comet.ParquetDatetimeRebaseV2Suite`
CI is green only because the suites are passed via `-DwildcardSuites`, which
ignores unmatched names; an explicit `-Dsuites` list fails with
`ClassNotFoundException`. The matrices therefore claim coverage that does not
run, and nothing prevented a stale name from being re-added.
## What changes are included in this PR?
- Add a forward declaration check to `dev/ci/check-suites.py`: a suite
listed in
a workflow must be declared as a `class`/`trait`/`object` in some
sourceset.
- Remove the six dead suite lines from `.github/workflows/pr_build_linux.yml`
and `.github/workflows/pr_build_macos.yml`.
`ParquetReadV1Suite` and `CometStringDecodeSuite` stay listed: the former is
declared in `ParquetReadSuite.scala`, the latter in the `spark-3.x` sourceset
used by the 3.4/3.5 profiles.
## How are these changes tested?
- `python3 dev/ci/check-suites.py` reports the six undeclared names (RED)
before
the removal, then prints `All workflow-listed suites are declared` and
exits 0
after it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
