github-actions[bot] commented on PR #25142: URL: https://github.com/apache/datafusion/pull/25142#issuecomment-5774547627
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion-ffi v55.0.0 (current) Built [ 56.944s] (current) Parsing datafusion-ffi v55.0.0 (current) Parsed [ 0.064s] (current) Building datafusion-ffi v55.1.0 (baseline) Built [ 55.903s] (baseline) Parsing datafusion-ffi v55.1.0 (baseline) Parsed [ 0.064s] (baseline) Checking datafusion-ffi v55.1.0 -> v55.0.0 (minor change) Checked [ 0.233s] 196 checks: 194 pass, 1 fail, 1 warn, 58 skip --- failure constructible_struct_adds_field: struct exhaustively constructible through public API adds field --- Description: A pub struct that could be exhaustively constructed with a literal using only public API has a new pub field, breaking existing exhaustive literals. ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/constructible_struct_adds_field.ron Failed in: field FFI_ScalarUDF.evaluate_bounds in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/udf/mod.rs:130 --- warning repr_c_plain_struct_fields_reordered: struct fields reordered in repr(C) struct --- Description: A public repr(C) struct had its fields reordered. This can change the struct's memory layout, possibly breaking FFI use cases that depend on field position and order. ref: https://doc.rust-lang.org/reference/type-layout.html#reprc-structs impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/repr_c_plain_struct_fields_reordered.ron Failed in: FFI_ScalarUDF.with_updated_config moved from position 14 to 15, in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/udf/mod.rs:136 Summary semver requires new major version: 1 major and 0 minor checks failed Warning produced 1 major and 0 minor level warnings Finished [ 114.879s] datafusion-ffi ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
