dwsmith1983 commented on code in PR #5867:
URL: https://github.com/apache/datafusion-comet/pull/5867#discussion_r4073216236
##########
spark/src/main/scala/org/apache/comet/serde/arrays.scala:
##########
@@ -843,10 +883,12 @@ object CometArrayPosition extends
CometExpressionSerde[ArrayPosition] with Array
}
}
-object CometArraysZip extends CometExpressionSerde[ArraysZip] {
+object CometArraysZip extends CometExpressionSerde[ArraysZip] with
CodegenDispatchFallback {
override def getUnsupportedReasons(): Seq[String] = Seq(
- "Not all input data types are supported; falls back to Spark for
unsupported types")
+ "Not all input data types are supported; unsupported types run through the
JVM codegen " +
Review Comment:
> Could it name them instead, something like map, interval and variant
element types?
Done in 0d61cac1e. The bullet now names what `isTypeSupported` declines:
map, calendar, day-time and year-month interval, variant, `TIME` and
user-defined element types, and a struct or inner array holding one of those.
The dispatcher sentence is gone since the generated header already says it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
