NoahKusaba commented on code in PR #2476: URL: https://github.com/apache/datafusion-ballista/pull/2476#discussion_r4078028986
########## docs/build.sh: ########## @@ -18,4 +18,4 @@ # under the License. rm -rf build -make html +SPHINXOPTS="-W --keep-going" make html Review Comment: Agreed. As it stood, the first warning to land would have silently stopped the site publishing. I've changed it so warnings are caught on the PR and never block publishing: - `docs.yaml` now also runs on pull requests that touch the docs, failing on warnings and skipping the `asf-site` checkout and push. - The deploy on `main` publishes even with warnings, since one can still sneak in when two PRs are only broken together. - `build.sh` stays strict by default so local builds catch them, and `SPHINXOPTS` overrides it (the deploy passes it empty). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
