NoahKusaba commented on PR #2480:
URL:
https://github.com/apache/datafusion-ballista/pull/2480#issuecomment-5787409199
Pushed a review pass (f22ec5a4):
- **The last pasted examples.** `extending-components.md` still had
hand-written copies of `custom-scheduler.rs`, `custom-executor.rs`, and
`custom-client.rs`, and they had already drifted. The client used an older
helper pair, and none showed their imports. They're now included from the
files, so every example the docs show comes from source.
- **Include anchors.** The example includes start after the license header's
last line instead of `:lines: 18-`, so a header change can't silently cut or
pad a snippet. All 10 rendered blocks are byte-identical to their source.
- **Clap variant.** The "keep the scheduler's command line" snippet now
applies both overrides, since S3 needs the session builder as well as the
config producer.
- **`examples/README.md`.** The table now says what each example needs:
- `custom-client` needs the custom scheduler and executor plus MinIO, not
just any cluster.
- `mtls-cluster` runs its own processes through `certs` / `scheduler` /
`executor` / `client` subcommands, so it isn't "in-process".
Heads-up: this and #2476 will conflict in `docs.yaml`. The fix is to add
this PR's two paths to #2476's shared path list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
