Visorgood commented on PR #6110: URL: https://github.com/apache/datafusion-comet/pull/6110#issuecomment-5790537513
Hey @sam-1112 ! You're right. `CometScanRule` only rejects a stored collated column, so `_2 COLLATE UTF8_LCASE` over a plain string column leaves `CometNativeScan` in place and the collation lands in a project above it – the exchange does reach the gate. VALUES gets there the same way, and `CometCollationSuite` already covers that. Rewrote the rationale in the description and added a test for the fallback. It also turns out the check matters beyond the shuffle: with it removed, listagg DISTINCT under utf8_lcase returns aabb instead of ab, because CometSort stays on a two-column collated key. Details in my reply to Andy. #6110 first works for me, thanks for offering to rebase #5802. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
