dwsmith1983 commented on code in PR #5365:
URL: https://github.com/apache/datafusion-comet/pull/5365#discussion_r4084980019
##########
pom.xml:
##########
@@ -45,11 +45,10 @@ under the License.
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
<java.version>17</java.version>
<!--
- Default Delta dep version (only consumed when `-Pcontrib-delta` is also
- active). Spark profiles override this: spark-3.5 -> 3.3.2, spark-4.1 ->
- 4.1.0. The top-level default lets Maven invocations that don't activate a
- Spark profile (e.g. `mvn -Pcontrib-delta spotless:apply`) resolve the
- property without an error.
+ Default Delta dep version, read by both Delta contribs (`-Pcontrib-delta`
Review Comment:
You are right, and the comment was wrong. `spark/pom.xml` sets
`delta.version` in its own Spark profiles for the in-tree contrib, and a
child's profile property wins over the parent's, so the spark module kept those
values while `contrib/delta-spark` read the overrides this branch added to the
root profiles. The root comment claimed one property served both.
`contrib/delta-spark` now reads its own `delta.spark.version`. The root pom
defines it once per Spark profile with the values the module already resolved
(2.4.0 on 3.4, 3.3.2 on 3.5, 4.0.1 on 4.0, 4.3.1 on 4.1 and 4.2) and a
top-level default of 4.3.1 for invocations with no Spark profile.
`delta.version` is left to the in-tree contrib and now resolves to exactly what
main gives the spark module on every profile, which also undoes a drift this
branch had introduced on spark-4.2. Both comments say which module reads which
property. Checked with `help:evaluate` on both modules across all five profiles.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
