sunchao commented on code in PR #5365:
URL: https://github.com/apache/datafusion-comet/pull/5365#discussion_r4104403879
##########
native/core/src/parquet/parquet_exec.rs:
##########
@@ -84,6 +89,9 @@ pub(crate) fn init_datasource_exec(
encryption_enabled: bool,
use_field_id: bool,
ignore_missing_field_id: bool,
+ rebase_from_file_metadata: bool,
Review Comment:
[P1] Update every caller when adding these three parameters. Three helpers
under `native/core/src/execution/operators/dynamic_filter/join/tests/` still
use the 18-argument signature: `timestamp_errors.rs:86`, `schema_errors.rs:65`,
and `schema_errors/partition_columns.rs:47`. Building any core unit-test
selection now fails because Rust compiles these helpers even when their tests
are filtered out. This also blocks CI’s `cargo clippy --all-targets
--workspace`. Supply `false, "", ""` at these ordinary-scan test callers,
matching the other updated fixtures.
Evidence: At the unmodified reviewed head, running `cargo test --locked
--offline -p datafusion-comet --no-default-features --features delta
datetime_rebase --no-run` from `native/` exits 101 with three E0061 errors:
“this function takes 21 arguments but 18 arguments were supplied.” The base
signature accepts 18 arguments. Adding only the three missing arguments at
those test call sites in a disposable copy allows the test binary to compile.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
