andygrove commented on PR #6066: URL: https://github.com/apache/datafusion-comet/pull/6066#issuecomment-5811719251
Thanks @sunchao. #6089 is approved and in the merge queue. I'll hold this PR until it lands and then add it to the queue. #6089 only touches docs files this PR doesn't change, so no rebase is needed. All of the removed keys are either in the `testing` category (`memoryOverhead`, `onHeap.memoryPool`, `shuffle.jvm.memoryFactor`) or marked `internal()` (`shuffle.jvm.memoryWaitTimeout`), so the exemption covers them. On the Spark 4.0 `SQLAppStatusListenerMemoryLeakSuite` failure: that test builds its own `SparkContext` without the Comet shuffle manager, so Comet is disabled for it (the log shows "Comet extension is disabled"). The only change since the previous fully green run was a comment. I've merged main to resolve the conflicts, and a new CI run is in progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
