alamb commented on code in PR #12151:
URL: https://github.com/apache/datafusion/pull/12151#discussion_r1730310755
##########
datafusion/core/tests/fuzz_cases/sort_fuzz.rs:
##########
@@ -136,9 +136,9 @@ impl SortTest {
.sort_spill_reservation_bytes,
);
- let runtime_config = RuntimeConfig::new()
- .with_memory_pool(Arc::new(GreedyMemoryPool::new(pool_size)));
- let runtime = Arc::new(RuntimeEnv::new(runtime_config).unwrap());
+ let runtime_env = RuntimeConfig::new()
+
.with_memory_pool(Arc::new(GreedyMemoryPool::new(pool_size))).build();
+ let runtime = Arc::new(runtime_env.unwrap());
Review Comment:
(note this is a test so I think it is ok to call unwrap() here)
##########
datafusion/core/tests/fuzz_cases/sort_fuzz.rs:
##########
@@ -136,9 +136,9 @@ impl SortTest {
.sort_spill_reservation_bytes,
);
- let runtime_config = RuntimeConfig::new()
- .with_memory_pool(Arc::new(GreedyMemoryPool::new(pool_size)));
- let runtime = Arc::new(RuntimeEnv::new(runtime_config).unwrap());
+ let runtime_env = RuntimeConfig::new()
Review Comment:
I agree with @comphead this now looks a bit strange -- I filed
https://github.com/apache/datafusion/issues/12156 with an idea of how to
improve it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
