gene-bordegaray commented on code in PR #24766:
URL: https://github.com/apache/datafusion/pull/24766#discussion_r4094836864
##########
datafusion/ffi/src/physical_expr/partitioning.rs:
##########
@@ -174,13 +180,28 @@ mod tests {
)?))
}
+ fn sampled_range_partitioning() -> Result<Partitioning> {
+ let ordering =
LexOrdering::new([PhysicalSortExpr::new_default(Arc::new(
+ Column::new("a", 0),
+ ))])
+ .expect("non-empty ordering");
+ let samples = [10, 20, 30, 40, 50]
+ .into_iter()
+ .map(|value|
SplitPoint::new(vec![ScalarValue::Int64(Some(value))]))
+ .collect();
+ Ok(Partitioning::Range(
+ RangePartitioning::try_new_with_samples(ordering, samples, 3)?,
+ ))
+ }
Review Comment:
is this needed with the test below?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
