github-actions[bot] commented on PR #25715: URL: https://github.com/apache/datafusion/pull/25715#issuecomment-5820472644
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion v55.1.0 (current) Built [ 64.160s] (current) Parsing datafusion v55.1.0 (current) Parsed [ 0.034s] (current) Building datafusion v55.1.0 (baseline) Built [ 60.294s] (baseline) Parsing datafusion v55.1.0 (baseline) Parsed [ 0.035s] (baseline) Checking datafusion v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.623s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 127.035s] datafusion Building datafusion-common v55.1.0 (current) Built [ 34.424s] (current) Parsing datafusion-common v55.1.0 (current) Parsed [ 0.062s] (current) Building datafusion-common v55.1.0 (baseline) Built [ 34.286s] (baseline) Parsing datafusion-common v55.1.0 (baseline) Parsed [ 0.065s] (baseline) Checking datafusion-common v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.637s] 223 checks: 222 pass, 1 fail, 0 warn, 31 skip --- failure constructible_struct_adds_field: struct exhaustively constructible through public API adds field --- Description: A pub struct that could be exhaustively constructed with a literal using only public API has a new pub field, breaking existing exhaustive literals. ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/constructible_struct_adds_field.ron Failed in: field ExecutionOptions.optional_filter_mode in /home/runner/work/datafusion/datafusion/datafusion/common/src/config.rs:950 field ExecutionOptions.optional_filter_max_pass_ratio in /home/runner/work/datafusion/datafusion/datafusion/common/src/config.rs:950 field ExecutionOptions.optional_filter_min_saving_ns_per_row in /home/runner/work/datafusion/datafusion/datafusion/common/src/config.rs:950 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 70.630s] datafusion-common Building datafusion-datasource-parquet v55.1.0 (current) Built [ 50.769s] (current) Parsing datafusion-datasource-parquet v55.1.0 (current) Parsed [ 0.037s] (current) Building datafusion-datasource-parquet v55.1.0 (baseline) Built [ 51.316s] (baseline) Parsing datafusion-datasource-parquet v55.1.0 (baseline) Parsed [ 0.035s] (baseline) Checking datafusion-datasource-parquet v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.151s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 103.602s] datafusion-datasource-parquet Building datafusion-physical-expr v55.1.0 (current) Built [ 29.628s] (current) Parsing datafusion-physical-expr v55.1.0 (current) Parsed [ 0.052s] (current) Building datafusion-physical-expr v55.1.0 (baseline) Built [ 29.837s] (baseline) Parsing datafusion-physical-expr v55.1.0 (baseline) Parsed [ 0.050s] (baseline) Checking datafusion-physical-expr v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.335s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 60.846s] datafusion-physical-expr Building datafusion-physical-plan v55.1.0 (current) Built [ 39.398s] (current) Parsing datafusion-physical-plan v55.1.0 (current) Parsed [ 0.171s] (current) Building datafusion-physical-plan v55.1.0 (baseline) Built [ 39.047s] (baseline) Parsing datafusion-physical-plan v55.1.0 (baseline) Parsed [ 0.169s] (baseline) Checking datafusion-physical-plan v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.767s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 80.812s] datafusion-physical-plan Building datafusion-proto v55.1.0 (current) Built [ 56.718s] (current) Parsing datafusion-proto v55.1.0 (current) Parsed [ 0.018s] (current) Building datafusion-proto v55.1.0 (baseline) Built [ 56.270s] (baseline) Parsing datafusion-proto v55.1.0 (baseline) Parsed [ 0.019s] (baseline) Checking datafusion-proto v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.119s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 114.649s] datafusion-proto Building datafusion-proto-models v55.1.0 (current) Built [ 25.997s] (current) Parsing datafusion-proto-models v55.1.0 (current) Parsed [ 0.133s] (current) Building datafusion-proto-models v55.1.0 (baseline) Built [ 26.264s] (baseline) Parsing datafusion-proto-models v55.1.0 (baseline) Parsed [ 0.133s] (baseline) Checking datafusion-proto-models v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 1.870s] 223 checks: 222 pass, 1 fail, 0 warn, 31 skip --- failure enum_variant_added: enum variant added on exhaustive enum --- Description: A publicly-visible enum without #[non_exhaustive] has a new variant. ref: https://doc.rust-lang.org/cargo/reference/semver.html#enum-variant-new impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/enum_variant_added.ron Failed in: variant ExprType:OptionalFilter in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/prost.rs:1686 variant ExprType:OptionalFilter in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/prost.rs:1686 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 55.617s] datafusion-proto-models Building datafusion-pruning v55.1.0 (current) Built [ 41.606s] (current) Parsing datafusion-pruning v55.1.0 (current) Parsed [ 0.015s] (current) Building datafusion-pruning v55.1.0 (baseline) Built [ 41.423s] (baseline) Parsing datafusion-pruning v55.1.0 (baseline) Parsed [ 0.016s] (baseline) Checking datafusion-pruning v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.080s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 84.193s] datafusion-pruning Building datafusion-sqllogictest v55.1.0 (current) Built [ 103.402s] (current) Parsing datafusion-sqllogictest v55.1.0 (current) Parsed [ 0.024s] (current) Building datafusion-sqllogictest v55.1.0 (baseline) Built [ 103.410s] (baseline) Parsing datafusion-sqllogictest v55.1.0 (baseline) Parsed [ 0.021s] (baseline) Checking datafusion-sqllogictest v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.090s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 209.971s] datafusion-sqllogictest ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
