asolimando commented on code in PR #25337:
URL: https://github.com/apache/datafusion/pull/25337#discussion_r4103354001
##########
datafusion/functions-aggregate/src/approx_percentile_cont.rs:
##########
@@ -198,11 +192,18 @@ impl ApproxPercentileCont {
if let Some(max_size) = tdigest_max_size {
ApproxPercentileAccumulator::new_with_max_size(
percentile,
+ is_descending,
data_type.clone(),
max_size,
)
+ .should_track_percentile()
Review Comment:
The benchmark confirms we are equal within noise limits, so I think it's a
marginal problem, I have no further comments!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
