github-actions[bot] commented on PR #25760: URL: https://github.com/apache/datafusion/pull/25760#issuecomment-5838393748
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion v55.1.0 (current) Built [ 64.155s] (current) Parsing datafusion v55.1.0 (current) Parsed [ 0.035s] (current) Building datafusion v55.1.0 (baseline) Built [ 60.607s] (baseline) Parsing datafusion v55.1.0 (baseline) Parsed [ 0.036s] (baseline) Checking datafusion v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.625s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 127.516s] datafusion Building datafusion-datasource v55.1.0 (current) Built [ 44.926s] (current) Parsing datafusion-datasource v55.1.0 (current) Parsed [ 0.032s] (current) Building datafusion-datasource v55.1.0 (baseline) Built [ 44.999s] (baseline) Parsing datafusion-datasource v55.1.0 (baseline) Parsed [ 0.032s] (baseline) Checking datafusion-datasource v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.262s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 91.475s] datafusion-datasource Building datafusion-datasource-parquet v55.1.0 (current) Built [ 52.046s] (current) Parsing datafusion-datasource-parquet v55.1.0 (current) Parsed [ 0.036s] (current) Building datafusion-datasource-parquet v55.1.0 (baseline) Built [ 52.012s] (baseline) Parsing datafusion-datasource-parquet v55.1.0 (baseline) Parsed [ 0.036s] (baseline) Checking datafusion-datasource-parquet v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.161s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 105.727s] datafusion-datasource-parquet Building datafusion-physical-expr v55.1.0 (current) Built [ 29.738s] (current) Parsing datafusion-physical-expr v55.1.0 (current) Parsed [ 0.050s] (current) Building datafusion-physical-expr v55.1.0 (baseline) Built [ 30.237s] (baseline) Parsing datafusion-physical-expr v55.1.0 (baseline) Parsed [ 0.051s] (baseline) Checking datafusion-physical-expr v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.360s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 61.433s] datafusion-physical-expr Building datafusion-physical-optimizer v55.1.0 (current) Built [ 42.453s] (current) Parsing datafusion-physical-optimizer v55.1.0 (current) Parsed [ 0.023s] (current) Building datafusion-physical-optimizer v55.1.0 (baseline) Built [ 42.908s] (baseline) Parsing datafusion-physical-optimizer v55.1.0 (baseline) Parsed [ 0.022s] (baseline) Checking datafusion-physical-optimizer v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.118s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 86.754s] datafusion-physical-optimizer Building datafusion-physical-plan v55.1.0 (current) Built [ 40.425s] (current) Parsing datafusion-physical-plan v55.1.0 (current) Parsed [ 0.171s] (current) Building datafusion-physical-plan v55.1.0 (baseline) Built [ 40.368s] (baseline) Parsing datafusion-physical-plan v55.1.0 (baseline) Parsed [ 0.170s] (baseline) Checking datafusion-physical-plan v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.645s] 223 checks: 222 pass, 1 fail, 0 warn, 31 skip --- failure constructible_struct_adds_private_field: struct no longer constructible due to new private field --- Description: A struct has a new non-public field that causes downstream code to be unable to construct it with a struct expression, including functional-update syntax. ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/constructible_struct_adds_private_field.ron Failed in: field ChildFilterPushdownResult.optional in /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/filter_pushdown.rs:181 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 83.377s] datafusion-physical-plan Building datafusion-proto v55.1.0 (current) Built [ 58.355s] (current) Parsing datafusion-proto v55.1.0 (current) Parsed [ 0.018s] (current) Building datafusion-proto v55.1.0 (baseline) Built [ 57.381s] (baseline) Parsing datafusion-proto v55.1.0 (baseline) Parsed [ 0.021s] (baseline) Checking datafusion-proto v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 0.132s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 117.375s] datafusion-proto Building datafusion-proto-models v55.1.0 (current) Built [ 26.220s] (current) Parsing datafusion-proto-models v55.1.0 (current) Parsed [ 0.131s] (current) Building datafusion-proto-models v55.1.0 (baseline) Built [ 25.763s] (baseline) Parsing datafusion-proto-models v55.1.0 (baseline) Parsed [ 0.136s] (baseline) Checking datafusion-proto-models v55.1.0 -> v55.1.0 (no change; assume patch) Checked [ 1.752s] 223 checks: 222 pass, 1 fail, 0 warn, 31 skip --- failure constructible_struct_adds_field: struct exhaustively constructible through public API adds field --- Description: A pub struct that could be exhaustively constructed with a literal using only public API has a new pub field, breaking existing exhaustive literals. ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/constructible_struct_adds_field.ron Failed in: field ParquetScanExecNode.optional_predicate_conjuncts in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/prost.rs:2048 field ParquetScanExecNode.optional_predicate_conjuncts in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/prost.rs:2048 field FilterExecNode.optional_conjuncts in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/prost.rs:1958 field FilterExecNode.optional_conjuncts in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/prost.rs:1958 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 55.172s] datafusion-proto-models ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
