dwsmith1983 commented on issue #5781: URL: https://github.com/apache/datafusion-comet/issues/5781#issuecomment-5873100072
> Evaluating nondeterministic children exactly once remains a separate issue in #5781. @sunchao #5867 covers that part: the `CASE WHEN child IS NOT NULL` guard in `size`, `array_append`, `arrays_zip` and `map_from_arrays` serialized the child twice, so a stateful child advanced each copy on its own. Both #5846 and #5867 change how `map_from_arrays` handles null keys in `maps.scala` and both add cases to `CometMapExpressionSuite`, so whichever lands second needs a rebase there. If #5846 goes first I will rebase #5867 onto it and re-check the null key order against the guard. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
