s5dsn-eqee commented on code in PR #2576:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2576#discussion_r4131774814
##########
src/dialect/mod.rs:
##########
@@ -939,6 +939,7 @@ pub trait Dialect: Debug + Any {
| Token::ExclamationMarkDoubleTilde
| Token::ExclamationMarkDoubleTildeAsterisk
| Token::Spaceship => Ok(p!(Eq)),
+ Token::Overlap if self.supports_double_ampersand_operator() =>
Ok(p!(And)),
Review Comment:
@LucaCappelletti94
Nit, not for this PR: supports_double_ampersand_operator() reads as
"supports &&", while it actually means "&& is boolean AND" (Generic/PG/Redshift
support && as overlap with the flag off). A name like
supports_double_ampersand_as_and() could be a follow-up; it's a public trait
method, so it'd be a breaking change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
