viirya commented on code in PR #873:
URL: https://github.com/apache/datafusion-comet/pull/873#discussion_r1733232669
##########
native/core/src/execution/datafusion/shuffle_writer.rs:
##########
@@ -798,7 +810,6 @@ impl ShuffleRepartitioner {
/// Writes buffered shuffled record batches into Arrow IPC bytes.
async fn shuffle_write(&mut self) -> Result<SendableRecordBatchStream> {
- let _timer = self.metrics.baseline.elapsed_compute().timer();
let num_output_partitions = self.num_output_partitions;
let mut buffered_partitions = self.buffered_partitions.lock().await;
let mut output_batches: Vec<Vec<u8>> = vec![vec![];
num_output_partitions];
Review Comment:
I checked how Spark calculates shuffle write time. Spark only includes the
time spent on disk operations. I tried to follow it so skipped the lines that
are not relevant to disk op.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
