rluvaton opened a new pull request, #25914: URL: https://github.com/apache/datafusion/pull/25914
## Which issue does this PR close? None ## Rationale for this change For the Row change: clear_shrink 0 should release all memory and return to the initial size so we can return to a memory footprint that we know we can hold (this was found in https://github.com/apache/datafusion/pull/24015) For the rest of the single group by fixes, the clear shrink left the struct in inconsistent state ## What changes are included in this PR? clear memory in rows and reset forgotten fields ## What is the testing strategy for this PR? Unit tests since for the group by it is not reached by our code but still leave in consistent state and it is a public trait for the rows, it came from other test start failing in https://github.com/apache/datafusion/pull/24015 so I just added unit test here as well ## Are there any user-facing changes? No -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
