coderfender commented on PR #4587: URL: https://github.com/apache/datafusion-comet/pull/4587#issuecomment-5933361410
@andygrove thanks for the review — addressed the top-level items: - **Golden files:** regenerated with `./dev/regenerate-golden-files.sh`; q10/q35/q45 (v1.4) and q35 (v2.7) now run the existence join natively (no more `[COMET: Unsupported join type ExistenceJoin(...)]`). - **`CometEmptyRelationExecSuite`:** updated the AQE test to expect the native `CometBroadcastHashJoinExec` over the `CometEmptyRelation` instead of asserting Spark fallback. - **PR description:** corrected — the flag now defaults to `true`, and `CometSortMergeJoinExec` is **not** wired (existence SMJ falls back to Spark). Updated the test/fallback summary and linked the two follow-ups (#6442, #6484). The per-comment replies above cover the inline threads (distinct fallback reasons, the `forceShuffledHashJoin` exclusion + test, the direct-marker/`IN`/string-key SQL coverage, and the `CometConf` cleanup). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
