viirya commented on issue #25856: URL: https://github.com/apache/datafusion/issues/25856#issuecomment-5936126784
Two positions from the review of #25815: - @mhilton suggests taking the absolute value of the interval: the bins are the same set for `stride` and `-stride`, so the sign shouldn't move them ([comment](https://github.com/apache/datafusion/pull/25815#discussion_r4123839765)). - @Toby1009 leans toward requiring a strictly positive interval and returning an error otherwise: a positive interval already handles timestamps before the origin, taking `abs` could hide an accidentally negative input, and callers who want to ignore the sign can do so explicitly ([comment](https://github.com/apache/datafusion/pull/25815#discussion_r4128921342)). This would also match PostgreSQL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
