adriangb commented on PR #25761: URL: https://github.com/apache/datafusion/pull/25761#issuecomment-5941827783
@neilconway after looking at the benchmark results I feel this optimization is not worth it. It does improve Q23 5x, but only Q23. Turning filter pushdown on improves Q23 25x and it wipes out the gains from this change, which is much more meaningful. I'd rather focus on getting that across the line. Does that sound reasonable? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
