ErikBPF commented on PR #6112: URL: https://github.com/apache/datafusion-comet/pull/6112#issuecomment-5951381066
Updated against pinned main `63fd1c9e` and addressed the cache-input/documentation feedback. Published ancestry is retained with an identical-tree merge, without force-pushing. Scale factor and partition count now come from the same job inputs used by actual generator arguments, restore/save cache keys, and dataset/query paths. Pinned generators, exact-match dataset restores, main-only saves and upstream Cargo policy are retained. The workflow README now describes this behavior accurately. Verification on Apollo: - The extended guard failed on the rebased pre-fix workflow with ten expected coupling diagnostics, then passed after the fix. - 15 input/mutation checks passed, along with CI/suite guards, formatting and actionlint. - The Maven reactor and RAT checks passed; Maven tests were explicitly skipped. - Actual Maven/Spark TPC-H region generation produced one Parquet file containing five rows. Pinned native stdout checks produced five region and 25 nation rows. - Independent source review passed; the final patch exactly matches the reviewed snapshot. Limitations: the local TPC-H build used `gcc -std=gnu17`, so this does not establish literal hosted compiler parity. TPC-DS native build remains blocked at `print.c:235` by `-Werror=format-security` after three repairs; no hardening/assertions were weakened. Full datasets, query suites, TPC-DS Spark generation and hosted cache behavior were not verified. Updated head: `f087cf42c3367cec43ceb54b20643462a93c469a` (tested tree unchanged from `7f68df22fe93635abce40c5ca66052c9879bcf23`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
