kosiew commented on code in PR #25373:
URL: https://github.com/apache/datafusion/pull/25373#discussion_r4164969217


##########
datafusion/core/tests/user_defined/expr_planner.rs:
##########
@@ -125,3 +132,27 @@ async fn test_question_filter() {
     +---+
     ");
 }
+

Review Comment:
   Could you add a case where the registered colon planner returns 
`PlannerResult::Original` for a Struct path? That would verify that a planner 
can defer colon handling and the built-in Struct-path lowering still produces 
the expected field access.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to