dwsmith1983 commented on code in PR #6059:
URL: https://github.com/apache/datafusion-comet/pull/6059#discussion_r4178591212
##########
native/core/src/parquet/objectstore/azure.rs:
##########
@@ -170,9 +965,11 @@ fn translate_hadoop_configs(
}
}
- // SAS tokens are scoped to
`fs.azure.sas.<container>.<account>[.<endpoint-suffix>]`.
- if let (Some(container), Some(account)) = (container, account) {
- if let Some(sas) = sas_value(configs, container, account) {
+ // The account-level fixed token wins over the container-scoped SAS token.
A blank
+ // token is left out so it never reaches the builder; validation reports
it as an
+ // error before the store is built.
+ if let Some((_, sas)) = active_sas_token(configs, account, container) {
+ if !sas.trim().is_empty() {
Review Comment:
> Could the fixed-token value be trimmed as Hadoop's
`getTrimmedPasswordString` does, with a regression covering whitespace before
the optional `?`?
Done in b9f9dddf0. The selected SAS token is trimmed before it reaches the
builder, whichever key supplied it. The new test builds the store from `"
?sig=synthetic&sv=2020-08-04&sp=r "` under the fixed token, its
container-scoped form and the WASB key, and checks that the parsed credential's
keys are `sig`, `sv` and `sp`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
