mikamikasuki opened a new pull request, #26043:
URL: https://github.com/apache/datafusion/pull/26043

   ## Which issue does this PR close?
   
   - Closes #25957.
   
   ## Rationale for this change
   
   With piecewise merge joins enabled, nested range-key comparisons can return 
incorrect results when an array contains an inner NULL. Struct range keys can 
also fail with an unsupported-sort error. Both cases should preserve SQL 
comparison semantics and execute successfully.
   
   ## What changes are included in this PR?
   
   - Fall back to `NestedLoopJoinExec` whenever either piecewise merge join 
range key has a nested datatype.
   - Update expected plans for existing nested-key right semi join cases.
   - Add SQL logic coverage for an array comparison containing an inner NULL 
and for a Struct comparison.
   
   ## What is the testing strategy for this PR?
   
   - `cargo test --test sqllogictests -- piecewise_merge_join_nested_nulls`
   - `cargo test --test sqllogictests -- pwmj`
   - `cargo fmt --all -- --check`
   - `cargo clippy --all-targets --all-features -- -D warnings`
   - Full extended workspace tests from the repository instructions: 
`RUST_BACKTRACE=1 cargo test --profile ci --exclude datafusion-examples 
--exclude datafusion-benchmarks --exclude datafusion-cli --workspace --lib 
--tests --bins --features 
avro,json,backtrace,extended_tests,recursive_protection,parquet_encryption`
   - `git diff --check`
   
   ## Are there any user-facing changes?
   
   Nested range joins return SQL-correct results when nested values contain 
NULLs, and Struct range keys no longer fail with an unsupported-sort error. 
There are no public API changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to