rich7420 opened a new pull request, #6652: URL: https://github.com/apache/datafusion-comet/pull/6652
## Which issue does this PR close? Part of #6634. ## Rationale for this change The existing SQL shift fixtures use INT operands and do not cover the BIGINT/INT combination that requires Comet to cast the shift amount. Moving the corresponding Scala test into a SQL fixture preserves this coverage in the SQL test framework. ## What changes are included in this PR? Add `bitwise/shift_mixed_types.sql` and remove the converted Scala test in the same change. The fixture retains both Parquet dictionary settings, the original four input rows (including the duplicate), and left/right shifts with literal and column amounts. It also covers values outside the INT range, BIGINT boundaries, zero, and NULL operands. | Original Scala test | SQL fixture | | --- | --- | | `CometBitwiseExpressionSuite`: `bitwise shift with different left/right types` | `bitwise/shift_mixed_types.sql` | This PR migrates one test from #6634. The other hash and bitwise tests remain outside this change. ## How are these changes tested? Plain `query` records retain Spark answer comparison and native operator assertions through `CometSqlFileTestSuite`. The original Scala test passed before conversion. The new fixture passed with dictionary encoding disabled and enabled on Spark 3.4, 3.5, 4.0, 4.1, and 4.2 (two tests per profile). Spark 3.5 was also built with `-Pstrict-warnings`. Spotless, Scalastyle, `git diff --check`, and Apache RAT passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
