asolimando commented on code in PR #25969: URL: https://github.com/apache/datafusion/pull/25969#discussion_r4184371532
########## docs/source/library-user-guide/upgrading/56.0.0.md: ########## @@ -428,6 +428,28 @@ part of `StatisticsRegistry::default_with_builtin_providers()`. - Remove `DefaultStatisticsProvider` from any custom provider chain; register no terminal provider instead (the walk falls back on its own). +### `StatisticsRegistry::default_with_builtin_providers` is deprecated + +`StatisticsRegistry::default_with_builtin_providers()` is deprecated in favor of +`StatisticsRegistry::with_experimental_providers()`. Most of the providers it Review Comment: Thanks for your feeback, @gabotechs. I was considering a two-phased approach, as the Join and Filter providers had improvements we want to keep, but I agree it's better to file issues for later than to keep duplicate code: - Multi-key join estimation is already tracked in #21583 (I added a [comment](https://github.com/apache/datafusion/issues/21583#issuecomment-5992705361)) - For NDV estimation after filters, I have filed #26052 NDV-based improvements are not covered by the existing benchmarks, as they don't provide NDV yet, but with the work of @Rich-T-kid (#25576) we might get there eventually and be able to merge those, once we can show the numbers get better. I have updated the PR to deprecate the bundled (formerly known as "built-in") providers entirely. Please take another look when you have time, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
