asolimando commented on code in PR #25969:
URL: https://github.com/apache/datafusion/pull/25969#discussion_r4185166634
##########
datafusion/physical-plan/src/operator_statistics/mod.rs:
##########
@@ -402,6 +397,11 @@ impl StatisticsRegistry {
/// 5. [`JoinStatisticsProvider`]
/// 6. [`LimitStatisticsProvider`]
/// 7. [`UnionStatisticsProvider`]
+ #[deprecated(
+ since = "56.0.0",
+ note = "the bundled providers are deprecated; the statistics walk uses
each operator's `statistics_from_inputs` when no provider matches"
+ )]
+ #[expect(deprecated)]
Review Comment:
The two follow-up issues are listed
[here](https://github.com/apache/datafusion/pull/25969#discussion_r4184371532),
which follow your proposal 1. to fold improvements in the built-in estimation.
For 2. I have filed https://github.com/apache/datafusion/issues/26055
following
https://datafusion.apache.org/contributor-guide/api-health.html#deprecation-guidelines
so we won't forget.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
