manuzhang opened a new pull request, #6678: URL: https://github.com/apache/datafusion-comet/pull/6678
## Which issue does this PR close? No issue filed. Found while verifying the 1.1.0 RC: the source tarball contains `.mvn/wrapper/maven-wrapper.jar`. ## Rationale for this change ASF release policy does not allow compiled code in a source package, and `maven-wrapper.jar` is a compiled binary. It has been in every release since the wrapper was added in #13 (February 2024), because the tarball is a `git archive` of the tag. Maven Wrapper 3.3 added a script-only distribution type for this case. `mvnw` and `mvnw.cmd` download and unpack the Maven distribution themselves, so there is no jar in the repository or at runtime. Excluding the jar from the tarball with `export-ignore` would also work, but it would leave the binary in the repository, and a tarball build would then download an unverified jar. ## What changes are included in this PR? - `mvnw`, `mvnw.cmd`: regenerated with `maven-wrapper-plugin` 3.3.4 (`-Dtype=only-script -Dmaven=3.9.6`). - `.mvn/wrapper/maven-wrapper.jar`: removed. - `.mvn/wrapper/maven-wrapper.properties`: adds `wrapperVersion=3.3.4` and `distributionType=only-script` and drops `wrapperUrl`. The plugin strips the license header, so this PR keeps it. Maven stays at 3.9.6 and still installs under `~/.m2/wrapper/dists`, the directory `.github/actions/maven-bootstrap` caches. That cache is keyed on `maven-wrapper.properties`, so each runner misses it once. The script unpacks the `.zip` distribution with `unzip` and falls back to the `.tar.gz` one when `unzip` is missing. The Docker builds that run `mvnw` (`dev/release/comet-rm`, `kube/Dockerfile`, `benchmarks/tpc/infra/docker/Dockerfile.build-comet`) already install `unzip`. ## How are these changes tested? On macOS aarch64 with JDK 17: - With an empty `MAVEN_USER_HOME`, `./mvnw -B --version` downloads and runs Maven 3.9.6. A second run reuses the installed copy. - `./mvnw -B validate` succeeds for the whole reactor. - `dev/ci/check-ci-config.py` passes. - `dev/release/run-rat.sh` on a `git archive` of this branch reports no unapproved licenses, and the archive contains no jar. Every CI job bootstraps through `./mvnw`, so this PR's CI exercises the Linux and macOS paths. `mvnw.cmd` is untested, since no CI job runs on Windows. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
