sunchao commented on PR #5972: URL: https://github.com/apache/datafusion-comet/pull/5972#issuecomment-6003336241
Addressed the eager-parent follow-up in c7c8c7340232d62727fe9c243646ee9ccb7ae681 and rebased the conflicting branch onto current main (0ac4dadae). DateSub and NextDay now share the binary eager-prefix rule, and CreateArray evaluates all children. Nullable left operands still protect masked right children, and a deferred parent output still keeps its projection in Spark. The new SQL regression failed on the preceding logic in both whole-stage codegen modes, reporting the three reviewed fallback reasons. With the fix, Spark 4.1.3 passed all 106 focused SQL/planner tests. Spark 3.5.9 passed strict main/test compilation and 105 tests; the existing Spark-4-only map-grouping test was canceled by its version guard. Coverage includes native admission, invalid weekdays under each eager parent, a leading-null array element, and null-masked DateSub/NextDay controls. The native/protobuf inputs match the verified CI library from main 74257803 (run 37346691204). Broader profile/Spark SQL CI is requested by the existing labels and is pending. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
