sunchao commented on code in PR #6076:
URL: https://github.com/apache/datafusion-comet/pull/6076#discussion_r4193325561
##########
native/spark-expr/src/agg_funcs/regr.rs:
##########
@@ -88,6 +91,7 @@ impl Regr {
name: impl Into<String>,
filter_var_by_pair_nulls: bool,
r2_constant_dependent_is_perfect_fit: bool,
+ eval_mode: EvalMode,
Review Comment:
[P2] Adding the required `eval_mode` argument leaves
`native/spark-expr/benches/aggregate_misc.rs:176` calling `Regr::new` with four
arguments. Consequently, benchmark compilation and the required all-targets
Clippy check fail with `E0061`, blocking CI before its Rust tests run. Could
you update that caller to pass `EvalMode::Legacy` (the mode is unused for
`RegrType::Slope`) and rerun the all-targets check?
Evidence: At the reviewed head, running `cargo check --offline -p
datafusion-comet-spark-expr --bench aggregate_misc` from `native/` exits 101:
`this function takes 5 arguments but 4 arguments were supplied`, pointing to
`spark-expr/benches/aggregate_misc.rs:176`. The benchmark is unchanged relative
to the supplied base. Exact-head upstream job
https://github.com/apache/datafusion-comet/actions/runs/37423867266/job/112140226269
and fork CI report the same failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
