rich7420 commented on code in PR #6076:
URL: https://github.com/apache/datafusion-comet/pull/6076#discussion_r4205366742
##########
native/spark-expr/src/agg_funcs/regr.rs:
##########
@@ -88,6 +91,7 @@ impl Regr {
name: impl Into<String>,
filter_var_by_pair_nulls: bool,
r2_constant_dependent_is_perfect_fit: bool,
+ eval_mode: EvalMode,
Review Comment:
Fixed in `37506bfd4`. The slope benchmark now passes `EvalMode::Legacy`;
slope does not consume the evaluation mode. I checked both `Regr::new` call
sites, and the planner already passes the captured mode. Full
workspace/all-targets Clippy with warnings denied and Rustfmt pass locally.
[Current-head
CI](https://github.com/apache/datafusion-comet/actions/runs/37474391984) now
passes, including Required Checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
