mohitgurav20 commented on PR #25716: URL: https://github.com/apache/datafusion/pull/25716#issuecomment-6016669976
Thanks for the detailed review and patience, @kosiew! I've pushed a final set of commits that fully resolves the Codecov coverage gaps. The persistent "partial" coverage was actually due to LLVM branch instrumentation on ? operators in both the production code and tests (where the Err branches were never hit). To fix this, I made deduplicate_record_batch_view_buffers infallible (since it mathematically cannot fail with matching schemas/column lengths), swapped test assertions to .expect(), and added targeted unit tests for the remaining edge cases (like the try_grow path). Everything is green locally. Let me know if we're good to merge! 6:19 PM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
