mbutrovich commented on code in PR #24510: URL: https://github.com/apache/datafusion/pull/24510#discussion_r4197946801
########## docs/source/contributor-guide/ai-policy.md: ########## @@ -0,0 +1,115 @@ +<!--- + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. +--> + +# AI Policy + +DataFusion has the following policy for AI-assisted PRs: + +- We welcome AI-assisted PRs from anyone. We do not welcome unreviewed "AI + dumps" (defined below). +- The PR author should have personally read the entire PR they submit and + **understand the core ideas end-to-end**. Authors should be ready to justify + and help reviewers understand the design and code during review. +- **Call out unknowns and assumptions**. It's okay to not fully understand + some bits of AI-generated code. Please point these cases out so we can work + together to clear up any concerns. Review Comment: Should this list point contributors to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html)? I raised this in [an earlier comment](https://github.com/apache/datafusion/pull/24510#issuecomment-6008541561), and the page at `fe8aea6` doesn't mention it yet. The guidance puts conditions on the contributor. The tool's terms can't restrict use of the output in a way that conflicts with the [Open Source Definition](https://opensource.org/osd). The output also has to meet one of three conditions: it isn't copyrightable, it contains no third-party material, or any third-party material in it is used with permission. As I read the rest of this page, it covers review burden and author understanding, so a contributor who follows it wouldn't learn about the licensing side. Iceberg's contributor guide has [a bullet for this](https://github.com/apache/iceberg/blob/f74aea1e68fc8161905a748f069c055f47ca64b5/site/docs/contribute.md?plain=1#L68) that we could adapt. What do you think about something like this? ```suggestion - **Call out unknowns and assumptions**. It's okay to not fully understand some bits of AI-generated code. Please point these cases out so we can work together to clear up any concerns. - **Respect ASF policy**. Make sure generated content does not introduce incompatible licenses or undisclosed third-party code. See the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for the conditions contributors must meet. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
