rich7420 opened a new pull request, #6731: URL: https://github.com/apache/datafusion-comet/pull/6731
## Which issue does this PR close? Closes #6618. Part of #6615. ## Rationale for this change SQL fixtures currently overwrite their optimizer exclusion config with ConstantFolding, preventing tests of folded complex literals and expressions that need other optimizer rules disabled. Mid-file SET can also leak undeclared settings into later fixtures, and config values containing `=` are split at the wrong position. ## What changes are included in this PR? - Add `ExcludeRules` and `ConstantFolding` directives, preserving Config/ConfigMatrix precedence and validating ineffective or contradictory optimizer settings. - Restore the complete SQLConf state after every fixture, including SET/RESET and failing statements or queries. Check the dispatcher error sentinel against the setting in effect at the error query. - Split Config/ConfigMatrix on the first `=`. Report malformed directives with the file and line, failing that fixture while allowing the other fixtures to run. - Migrate one existing multirow folded map/NULL array regression to SQL, add a native `abs(NULL)` fixture, and cover optimized-plan changes and configuration isolation in the existing suites. - Document the directives and configuration isolation behavior. Temporary view cleanup remains outside this change. ## How are these changes tested? Spark 3.4, 3.5, 4.0, 4.1 and 4.2: 30 targeted tests per profile passed from a clean root-reactor build (150 total), with no failed, canceled, ignored, pending or aborted tests. The selected tests include the parser suite, framework regressions, both new SQL fixtures and the existing ANSI SET/timezone matrix fixture. The native library was built from the same checkout and supplied explicitly through `jni.dir`; all Maven tests use the root reactor. Negative controls confirm that restoring the old equals parser and removing restoration of newly set keys each make their regression fail. A temporary malformed fixture produced exactly one failed test alongside 30 passing tests, with no suite aborts and a file/line diagnostic; the temporary resource was removed afterwards. Apache RAT passed against the exact reviewed source tree. Maven style/Spotless checks, targeted Prettier, git diff whitespace checks and workflow suite registration checks passed. The full Comet SQL fixture suite, upstream Spark SQL suites and Iceberg suites were not run locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
