itsjunetime commented on code in PR #12135:
URL: https://github.com/apache/datafusion/pull/12135#discussion_r1737057456
##########
datafusion/core/src/datasource/physical_plan/parquet/mod.rs:
##########
@@ -685,10 +686,12 @@ impl ExecutionPlan for ParquetExec {
partition_index: usize,
ctx: Arc<TaskContext>,
) -> Result<SendableRecordBatchStream> {
- let projection = match
self.base_config.file_column_projection_indices() {
- Some(proj) => proj,
- None => (0..self.base_config.file_schema.fields().len()).collect(),
- };
+ let projection = self
Review Comment:
Yup - moved to https://github.com/apache/datafusion/pull/12240
##########
datafusion/physical-expr/src/expressions/binary.rs:
##########
@@ -133,12 +134,15 @@ impl std::fmt::Display for BinaryExpr {
}
/// Invoke a boolean kernel on a pair of arrays
-macro_rules! boolean_op {
- ($LEFT:expr, $RIGHT:expr, $OP:ident) => {{
- let ll = as_boolean_array($LEFT).expect("boolean_op failed to downcast
array");
- let rr = as_boolean_array($RIGHT).expect("boolean_op failed to
downcast array");
- Ok(Arc::new($OP(&ll, &rr)?))
- }};
+#[inline]
Review Comment:
Yup - moved to https://github.com/apache/datafusion/pull/12240
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
