kosiew commented on PR #26074: URL: https://github.com/apache/datafusion/pull/26074#issuecomment-6032496963
@comphead > `State::size` naming, spare-capacity setup, and inline-only arm documentation. `State::size` also excludes its inline descriptor; I’ll rename it `heap_size` for consistency. `GroupOrdering::try_new` clones the indices, so this setup tests retained-capacity accounting through the direct partial constructor, not that factory. I’ll keep that guard using `Vec::with_capacity(32)` plus `push(0)`, drop the redundant capacity assertion, and comment that `None | Full(_)` holds only inline state. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
