kosiew commented on code in PR #26074:
URL: https://github.com/apache/datafusion/pull/26074#discussion_r4204353077
##########
datafusion/physical-plan/src/aggregates/order/partial.rs:
##########
@@ -267,9 +266,10 @@ impl GroupOrderingPartial {
Ok(())
}
- /// Return the size of memory allocated by this structure
- pub(crate) fn size(&self) -> usize {
- size_of::<Self>() + self.order_indices.allocated_size() +
self.state.size()
+ /// Returns retained heap allocations, excluding the inline descriptor
+ /// already counted by [`super::GroupOrdering::size`].
+ pub(crate) fn heap_size(&self) -> usize {
+ self.order_indices.allocated_size() + self.state.size()
Review Comment:
#26099
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
