andygrove commented on issue #2730:
URL:
https://github.com/apache/datafusion-comet/issues/2730#issuecomment-6042424030
All of the `timeZoneId.getOrElse("UTC")` sites listed here are gone. #6351
replaced them with `CometTimeZone.nativeId`, which normalizes the timezone each
serde passes to native code and reports the expression as unsupported when
native code can't represent its timezone, so it falls back or runs in the
codegen dispatcher. An expression with no timezone still gets `"UTC"`, but
Spark only leaves the timezone unset on casts that don't use it, which the
audit in #6335 confirmed across the test suites.
The hard-coded `UTC` in `to_arrow_datatype` is intended. Every
`TimestampType` value in a native plan is labelled `Timestamp(Microsecond,
"UTC")`, and the session timezone travels with each expression instead of with
the values. `docs/source/contributor-guide/timezones.md` describes that model.
Closing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
