andygrove opened a new issue, #6767: URL: https://github.com/apache/datafusion-comet/issues/6767
### What is the problem the feature request solves? Spark accepts arbitrary configuration keys, so a typo in a Comet setting is silently ignored. For example: ``` --conf spark.comet.exec.enabld=true ``` looks plausible but has no effect. This can leave users believing that a Comet feature is enabled, disabled, or tuned when the intended configuration was never read. ### Describe the potential solution When Comet initializes or otherwise inspects the active Spark/SQL configuration, log a warning for each explicitly set key under `spark.comet.*` that Comet does not recognize. The validation should: - Treat registered `CometConf` keys and supported deprecated/alternative keys as recognized. - Account for supported dynamic or pass-through key families, such as the DataFusion configuration namespace, so valid settings do not produce false positives. - Emit at most one warning per unrecognized key. - Include the offending key in the message; a "did you mean ...?" suggestion for a close known key would be useful but is not required. - Have tests covering an unknown key, a known key, an alternative key, and any supported dynamic namespace. For example: ``` WARN Unrecognized Comet configuration key 'spark.comet.exec.enabld'. Did you mean 'spark.comet.exec.enabled'? ``` ### Additional context `CometConf.allConfs` already tracks registered Comet configuration entries, and `ConfigEntry.alternatives` tracks accepted aliases. Those appear to provide most of the information needed to distinguish known keys from likely typos. ### Willingness to contribute I cannot contribute a fix for this bug at this time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
