dwsmith1983 commented on PR #5613: URL: https://github.com/apache/datafusion-comet/pull/5613#issuecomment-6059048430
> Resolve the existing P2 by preserving task-entry safety without parking an otherwise satisfiable allocation solely for the anchor byte. The anchor is gone. The pool now makes the same Spark calls as main for every operation, so with another task holding 90 of 100 bytes a first `try_grow(10)` or `grow(10)` is granted with one call, and with the other task at 70, `try_grow(30)` and `grow(30)` get all 30. Those cases are tests in `fair_pool.rs` now, with nothing pre-seeded. Task-entry safety now comes from #6310, which you approved: `CometTaskMemoryManager.acquireMemory` asks Spark again when a release empties the task's balance under a waiting acquire. That covers the release coming from another native thread as well as from a JVM consumer of the task, so this PR should merge after #6310. With the anchor gone the teardown wait went too: `task_shared.rs`, `spill_replay.rs` and `mod.rs` match main again, and `createPlan` no longer waits for the previous pool's teardown. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
