waynexia commented on code in PR #12008: URL: https://github.com/apache/datafusion/pull/12008#discussion_r1738065441
########## .github/workflows/rust.yml: ########## @@ -39,6 +39,14 @@ on: workflow_dispatch: jobs: + # Check license header + license-header-check: + runs-on: ubuntu-20.04 + name: Check License Header + steps: + - uses: actions/checkout@v4 + - uses: korandoru/hawkeye@v5 Review Comment: After some searching, it seems like RAT is provided by a 3rd-party workflow and hasn't been moved into Apache org (https://issues.apache.org/jira/browse/RAT-337). Other projects that use RAT are not using its workflow directly but via some workaround like us via Python (e.g. `apache/arrow` is via pre-commit tool [here](https://github.com/apache/arrow/blob/07420b0c56066326bd409e9537ee3d43ab6b1a51/.pre-commit-config.yaml#L24-L31)). I'm not sure if RAT is a mature way in GitHub Action. The [RAT check](https://github.com/apache/datafusion/blob/main/dev/release/run-rat.sh) in our repo hasn't been changed for 3 years 🤣 Maybe we need another tool for better check capability. I find OpenDAL also uses this workflow [here](https://github.com/apache/opendal/blob/e869a70a63c0e6ccaaeabe7678ec77ecd614f5ac/.github/workflows/ci_check.yml#L46-L54). So we can assume it's in the approved list? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
