neilconway commented on code in PR #25949:
URL: https://github.com/apache/datafusion/pull/25949#discussion_r4230849233
##########
datafusion/sql/src/unparser/expr.rs:
##########
@@ -1261,10 +1261,16 @@ impl Unparser<'_> {
.to_string()
};
+ let tz = if tz.is_some() {
+ &Some(Arc::from("+00:00"))
+ } else {
+ &None
+ };
Review Comment:
Sorry, I don't follow. The PR description says that the fix is to
```
Pass the literal's tz through to Dialect::timestamp_cast_dtype instead of
&None
```
But it doesn't seem like that's what we're doing above? I'd have expected
that we omit this code and just pass
`self.dialect.timestamp_cast_dtype(&time_unit, &tz.cloned())` below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
